Source/core/editing/Selection.idl - Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Selection.idl

Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/Selection.idl

diff --git a/Source/core/editing/Selection.idl b/Source/core/editing/Selection.idl

index a7ad07b414cbc02147f84e07a9b0386b600e5cb4..e1b3fbbe184f3717b4790b836fbd859c80cfdc3b 100644

--- a/Source/core/editing/Selection.idl

+++ b/Source/core/editing/Selection.idl

@@ -60,8 +60,7 @@

[Default=Undefined] optional long extentOffset);

[RaisesException, TypeChecking=Interface] void selectAllChildren(Node node);

[CustomElementCallbacks] void deleteFromDocument();

- // TODO(philipj): The arguments should not be optional.

- [MeasureAs=SelectionContainsNode] boolean containsNode([Default=Undefined] optional Node node, [Default=Undefined] optional boolean allowPartialContainment);

+ [MeasureAs=SelectionContainsNode, TypeChecking=Interface] boolean containsNode(Node node, optional boolean allowPartialContainment = false);

// TODO(philipj): The spec does not use [NotEnumerable]. See also:

// https://codereview.chromium.org/345983004/

// https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179

« no previous file with comments | « Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »