Source/core/editing/DOMSelection.cpp - Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/DOMSelection.cpp

Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/containsNode.html ('K') | « LayoutTests/editing/selection/containsNode-expected.txt ('k') | Source/core/editing/Selection.idl » ('j') | Source/core/editing/Selection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/DOMSelection.cpp

diff --git a/Source/core/editing/DOMSelection.cpp b/Source/core/editing/DOMSelection.cpp

index 0468dbc358f711e80df97db3fcc79745064fb840..f066f1c539822460586735c07af8632e1ff13ec4 100644

--- a/Source/core/editing/DOMSelection.cpp

+++ b/Source/core/editing/DOMSelection.cpp

@@ -461,7 +461,7 @@ bool DOMSelection::containsNode(const Node* n, bool allowPartial) const

FrameSelection& selection = m_frame->selection();

- if (!n || m_frame->document() != n->document() || selection.isNone())

+ if (m_frame->document() != n->document() || selection.isNone())

return false;

unsigned nodeIndex = n->nodeIndex();