LayoutTests/fast/events/drag-selects-image.html - Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/drag-selects-image.html

Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/DOMSelection-DocumentType-expected.txt ('K') | « LayoutTests/fast/events/drag-selects-culled-inlines-expected.txt ('k') | Source/core/editing/Selection.idl » ('j') | Source/core/editing/Selection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/drag-selects-image.html

diff --git a/LayoutTests/fast/events/drag-selects-image.html b/LayoutTests/fast/events/drag-selects-image.html

index 289a2c20199546c87b56f7f968df050a6457af65..765bc0691eda56df06b552168c8d1947daa553f0 100644

--- a/LayoutTests/fast/events/drag-selects-image.html

+++ b/LayoutTests/fast/events/drag-selects-image.html

@@ -31,7 +31,7 @@

log('Dragging image in editable area...');

dragNowhere(document.getElementById('imageTwo'));

log(window.getSelection().rangeCount + ' range(s) selected');

- if (window.getSelection().rangeCount && window.getSelection().containsNode(document.getElementById('imageTwo')))

+ if (window.getSelection().rangeCount && window.getSelection().containsNode(document.getElementById('imageTwo'), false))

log('imageTwo is selected');

}

</script>