LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js - Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/DOMSelection-DocumentType-expected.txt ('K') | « LayoutTests/editing/selection/DOMSelection-DocumentType-expected.txt ('k') | LayoutTests/fast/events/drag-selects-culled-inlines.html » ('j') | Source/core/editing/Selection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

diff --git a/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js b/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

index d44f417b258c06a0f2d196af2b56e0e7a6265ced..c70aadbf7e625d693c5eccf33d1471982bd29635 100644

--- a/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

+++ b/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

@@ -17,9 +17,9 @@ shouldBeNull("sel.anchorNode");

sel.extend(docType, 0);

shouldBeNull("sel.anchorNode");

-sel.containsNode(docType);

+sel.containsNode(docType, false);

shouldBeNull("sel.anchorNode");

-shouldBeFalse("sel.containsNode(docType)");

+shouldBeFalse("sel.containsNode(docType, false)");

var successfullyParsed = true;