The node and allowPartialContainment arguments for Selection API should not be optional

Source/core/editing/Selection.idl

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 42 matching lines @@
     // TODO(philipj): The offset argument should not have a default value.
     [RaisesException, TypeChecking=Interface] void extend(Node node, optional long offset = 0);
     // TODO(philipj): The arguments should be anchorNode, anchorOffset,
     // focusNode and focusOffset, and none of them should be optional.
     [MeasureAs=SelectionSetBaseAndExtent, RaisesException] void setBaseAndExtent([Default=Undefined] optional Node baseNode,
                                                                                  [Default=Undefined] optional long baseOffset,
                                                                                  [Default=Undefined] optional Node extentNode,
                                                                                  [Default=Undefined] optional long extentOffset);
     [RaisesException, TypeChecking=Interface] void selectAllChildren(Node node);
     [CustomElementCallbacks] void deleteFromDocument();
-    // TODO(philipj): The arguments should not be optional.
-    [MeasureAs=SelectionContainsNode] boolean containsNode([Default=Undefined] optional Node node, [Default=Undefined] optional boolean allowPartialContainment);
+    [MeasureAs=SelectionContainsNode] boolean containsNode(Node node, boolean allowPartialContainment);

[philipj_slow, 2015/08/27 09:15:32]

Please also add TypeChecking=Interface so that passing null for the first
argument will throw an exception. It's better to change this once only.

With this change you should also be able to remove the internal null check, as
long as the API isn't called from any other place where node can be null.

[tanay.c, 2015/08/28 08:52:32]

Done.

     // TODO(philipj): The spec does not use [NotEnumerable]. See also:
     // https://codereview.chromium.org/345983004/
     // https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179
     [NotEnumerable] stringifier DOMString ();
 
     // Non-standard APIs
 
     // https://github.com/w3c/selection-api/issues/34
     [MeasureAs=SelectionBaseNode] readonly attribute Node? baseNode;
     [MeasureAs=SelectionBaseOffset] readonly attribute long baseOffset;
     [MeasureAs=SelectionExtentNode] readonly attribute Node? extentNode;
     [MeasureAs=SelectionExtentOffset] readonly attribute long extentOffset;
 
     // https://github.com/w3c/selection-api/issues/14
     [MeasureAs=SelectionType] readonly attribute DOMString type;
 
     // https://github.com/w3c/selection-api/issues/36
     [MeasureAs=SelectionEmpty] void empty();
 
     // https://github.com/w3c/selection-api/issues/37
     [MeasureAs=SelectionModify] void modify([Default=Undefined] optional DOMString alter,
                                             [Default=Undefined] optional DOMString direction,
                                             [Default=Undefined] optional DOMString granularity);
 
     // https://github.com/w3c/selection-api/issues/38
     [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException] void setPosition(Node? node, optional long offset = 0);
 };