LayoutTests/editing/selection/DOMSelection-DocumentType-expected.txt - Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/DOMSelection-DocumentType-expected.txt

Issue 1308663003: The node and allowPartialContainment arguments for Selection API should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Test to check if setBaseAndExtent guard node with null owner document (Bug 31680 )	1 Test to check if setBaseAndExtent guard node with null owner document (Bug 31680 )

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6 PASS sel.anchorNode is null	6 PASS sel.anchorNode is null

7 PASS sel.anchorNode is null	7 PASS sel.anchorNode is null

8 PASS sel.collapse(docType) threw exception InvalidNodeTypeError: Failed to execu te 'collapse' on 'Selection': The node provided is of type 'c'..	8 PASS sel.collapse(docType) threw exception InvalidNodeTypeError: Failed to execu te 'collapse' on 'Selection': The node provided is of type 'c'..

9 PASS sel.anchorNode is null	9 PASS sel.anchorNode is null

10 PASS sel.anchorNode is null	10 PASS sel.anchorNode is null

11 PASS sel.anchorNode is null	11 PASS sel.anchorNode is null

12 PASS sel.containsNode(docType) is false	12 PASS sel.containsNode(docType, false) is false
	philipj_slow 2015/08/27 09:15:32 Seeing this I think it would make sense to keep th Seeing this I think it would make sense to keep the second argument optional, and have pinged a spec issue I filed on this: https://github.com/w3c/selection-api/issues/30 I think you can proceed on the assumption that the second argument will be optional, but that the first argument will be required. The CL can land as soon as the spec is changed or the editor agrees in principal to the change. tanay.c 2015/08/28 08:52:32 Done. Show quoted text On 2015/08/27 09:15:32, philipj wrote: > Seeing this I think it would make sense to keep the second argument optional, > and have pinged a spec issue I filed on this: > https://github.com/w3c/selection-api/issues/30 > > I think you can proceed on the assumption that the second argument will be > optional, but that the first argument will be required. The CL can land as soon > as the spec is changed or the editor agrees in principal to the change. Done.
13 PASS successfullyParsed is true	13 PASS successfullyParsed is true

14	14

15 TEST COMPLETE	15 TEST COMPLETE

16	16

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js » ('j') | Source/core/editing/Selection.idl » ('J')