Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: Source/devtools/front_end/audits/AuditRules.js

Issue 1308663002: DevTools: simplify WI.CSSProperty and WI.CSSStyleDeclaration interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 883 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 } 894 }
895 } 895 }
896 } 896 }
897 if (completeSrc) 897 if (completeSrc)
898 src = completeSrc; 898 src = completeSrc;
899 899
900 if (styles.computedStyle.get("position") === "absolute") 900 if (styles.computedStyle.get("position") === "absolute")
901 return; 901 return;
902 902
903 if (styles.attributesStyle) { 903 if (styles.attributesStyle) {
904 var widthFound = !!styles.attributesStyle.getLiveProperty("width "); 904 var widthFound = !!styles.attributesStyle.getPropertyValue("widt h");
905 var heightFound = !!styles.attributesStyle.getLiveProperty("heig ht"); 905 var heightFound = !!styles.attributesStyle.getPropertyValue("hei ght");
906 } 906 }
907 907
908 var inlineStyle = styles.inlineStyle; 908 var inlineStyle = styles.inlineStyle;
909 if (inlineStyle) { 909 if (inlineStyle) {
910 if (inlineStyle.getPropertyValue("width") !== "") 910 if (inlineStyle.getPropertyValue("width") !== "")
911 widthFound = true; 911 widthFound = true;
912 if (inlineStyle.getPropertyValue("height") !== "") 912 if (inlineStyle.getPropertyValue("height") !== "")
913 heightFound = true; 913 heightFound = true;
914 } 914 }
915 915
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
1647 result.violationCount = badUrls.length; 1647 result.violationCount = badUrls.length;
1648 }, 1648 },
1649 1649
1650 _collectorCallback: function(matchingResourceData, request, cookie) 1650 _collectorCallback: function(matchingResourceData, request, cookie)
1651 { 1651 {
1652 matchingResourceData[request.url] = (matchingResourceData[request.url] | | 0) + cookie.size(); 1652 matchingResourceData[request.url] = (matchingResourceData[request.url] | | 0) + cookie.size();
1653 }, 1653 },
1654 1654
1655 __proto__: WebInspector.AuditRules.CookieRuleBase.prototype 1655 __proto__: WebInspector.AuditRules.CookieRuleBase.prototype
1656 } 1656 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698