Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308633005: Make classes and structures in core/style, core/plugins and core/streams fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/style, core/plugins and core/streams fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -4 lines) Patch
M Source/core/plugins/testing/DictionaryPluginPlaceholder.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/plugins/testing/DocumentFragmentPluginPlaceholder.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/streams/ReadableStreamImpl.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/style/AppliedTextDecoration.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/BasicShapes.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/style/BorderData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/BorderEdge.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/style/BorderImageLength.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/BorderImageLengthBox.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/BorderValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/CachedUAStyle.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/style/CollapsedBorderValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/CounterDirectives.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/DataRef.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/FillLayer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/GridCoordinate.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/style/GridLength.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/GridPosition.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/GridResolvedPosition.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/GridTrackSize.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/LineClampValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/NinePieceImage.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/OutlineValue.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/style/SVGComputedStyleDefs.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/style/StyleContentAlignmentData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/StyleDifference.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/StyleMotionData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/StyleScrollSnapData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/StyleSelfAlignmentData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/TransformOrigin.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-08-28 09:38:03 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-08-28 09:43:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308633005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308633005/1
5 years, 3 months ago (2015-08-28 10:20:01 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 10:24:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201390

Powered by Google App Engine
This is Rietveld 408576698