[WebSocket] Merge duplicated HTTP headers for devtools

[WebSocket] Merge duplicated HTTP headers for devtools

The new WebSocket implementation receives HTTP headers on
the opening handshake from the browser process.
The headers may be duplicated, e.g. there are two "Foo" headers.
In order to show duplicated headers in devtools, this CL merges them
during storing them to HTTPHeaderMap.
This CL changes the existing WebSocket behavior as well.

R=tyoshino
BUG=310405
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165044

[tyoshino (SeeGerritForStatus), 2014-01-09 07:29:09]

lgtm

https://codereview.chromium.org/130863002/diff/30001/Source/platform/network/...
File Source/platform/network/WebSocketHandshakeRequest.cpp (right):

https://codereview.chromium.org/130863002/diff/30001/Source/platform/network/...
Source/platform/network/WebSocketHandshakeRequest.cpp:54: // It is important
that values are separated by '\n', not comma, otherwise Set-Cookie header is not
parseable.
how about just explain that we're building input for inspector in the special
format inspector expects?

[yhirano, 2014-01-09 07:43:16]

https://codereview.chromium.org/130863002/diff/30001/Source/platform/network/...
File Source/platform/network/WebSocketHandshakeRequest.cpp (right):

https://codereview.chromium.org/130863002/diff/30001/Source/platform/network/...
Source/platform/network/WebSocketHandshakeRequest.cpp:54: // It is important
that values are separated by '\n', not comma, otherwise Set-Cookie header is not
parseable.
On 2014/01/09 07:29:09, tyoshino wrote:
> how about just explain that we're building input for inspector in the special
> format inspector expects?

Done.

[tyoshino (SeeGerritForStatus), 2014-01-09 07:51:24]

lgtm

[yhirano, 2014-01-09 07:53:01]

+tkent for OWNER review

[tkent, 2014-01-14 00:25:14]

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
File Source/platform/network/WebSocketHandshakeRequest.cpp (right):

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
Source/platform/network/WebSocketHandshakeRequest.cpp:50: // static
We don't add "// static" comment in Blink.

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
File Source/platform/network/WebSocketHandshakeRequest.h (right):

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
Source/platform/network/WebSocketHandshakeRequest.h:34: #include
"platform/network/HTTPHeaderMap.h"
Do we need to include this?

[yhirano, 2014-01-14 01:17:04]

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
File Source/platform/network/WebSocketHandshakeRequest.cpp (right):

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
Source/platform/network/WebSocketHandshakeRequest.cpp:50: // static
On 2014/01/14 00:25:14, tkent wrote:
> We don't add "// static" comment in Blink.

Done.

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
File Source/platform/network/WebSocketHandshakeRequest.h (right):

https://codereview.chromium.org/130863002/diff/140001/Source/platform/network...
Source/platform/network/WebSocketHandshakeRequest.h:34: #include
"platform/network/HTTPHeaderMap.h"
On 2014/01/14 00:25:14, tkent wrote:
> Do we need to include this?

Done.

[tkent, 2014-01-14 01:18:44]

Can you add a test for DevTools?

[yhirano, 2014-01-14 03:42:22]

done

In addition to that, renamed web-socket-frame.html to websocket-frame.html.

[tkent, 2014-01-14 03:54:27]

On 2014/01/14 03:42:22, yhirano wrote:
> done

What part of the test demonstrates the new behavior?

[yhirano, 2014-01-14 03:58:44]

On 2014/01/14 03:54:27, tkent wrote:
> On 2014/01/14 03:42:22, yhirano wrote:
> > done
> 
> What part of the test demonstrates the new behavior?

duplicated-headers returns multiple values for the header 'foo'.
The test examines that no header values are lost.

Without this cl, some header values will be lost because HTTPHeaderMap::add(key,
value) does nothing if the map already has the key.

[tkent, 2014-01-14 04:01:42]

lgtm

> duplicated-headers returns multiple values for the header 'foo'.
> The test examines that no header values are lost.
> 
> Without this cl, some header values will be lost because
HTTPHeaderMap::add(key,
> value) does nothing if the map already has the key.

Thanks.  I understand.

[commit-bot: I haz the power, 2014-01-14 04:07:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/130863002/310001

[commit-bot: I haz the power, 2014-01-14 07:26:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/130863002/510001

[commit-bot: I haz the power, 2014-01-14 08:41:17]

Change committed as 165044