Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1308623003: Assume crashed RenderWidgetHost to be invisible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply the change to all platforms Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 71ec817e8d78b47bf48cc58b0cf878138f5921cd..710de9b74f095e3affdeb2cd5d3545fbcf44201d 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -405,7 +405,7 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
frame_tree_node_->IsMainFrame());
}
- // If the renderer crashed, then try to create a new one to satisfy this
+ // If the renderer isn't live, then try to create a new one to satisfy this
// navigation request.
if (!dest_render_frame_host->IsRenderFrameLive()) {
// Instruct the destination render frame host to set up a Mojo connection
@@ -432,6 +432,16 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
if (dest_render_frame_host->GetView())
dest_render_frame_host->GetView()->Hide();
} else {
+ if (dest_render_frame_host->GetView() &&
no sievers 2015/09/08 19:56:34 Can you put a comment saying that after a renderer
Jaekyun Seok (inactive) 2015/09/08 23:03:55 Done.
+ dest_render_frame_host->GetView()->IsShowing() ==
+ delegate_->IsHidden()) {
+ if (delegate_->IsHidden()) {
+ dest_render_frame_host->GetView()->Hide();
+ } else {
+ dest_render_frame_host->GetView()->Show();
+ }
+ }
+
// TODO(nasko): This is a very ugly hack. The Chrome extensions process
// manager still uses NotificationService and expects to see a
// RenderViewHost changed notification after WebContents and

Powered by Google App Engine
This is Rietveld 408576698