[reland] SegmentedString::push() should always push a char in front

[reland] SegmentedString::push() should always push a char in front

Reland: Fixed "notEnoughCharacters" not initialized.

Before this CL, SegmentedString::push() had an exotic behavior, where
two consecutive push would swap its order.

This CL changes the push() implementation so that it would always push
the new char in front of the SegmentedString.
This CL also updates the HTMLEntityParser code which relied on the behavior.

BUG=None
TEST={SegmentedStringTest,HTMLEntityParserTest}.*

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201294

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201369

[kouhei (in TOK), 2015-08-27 03:50:42]

kouhei@chromium.org changed reviewers:
+ tkent@chromium.org, tzik@chromium.org

[kouhei (in TOK), 2015-08-27 03:50:47]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-27 03:51:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308573006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308573006/1

[tkent, 2015-08-27 04:18:13]

lgtm

[commit-bot: I haz the power, 2015-08-27 04:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 04:31:07]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[kouhei (in TOK), 2015-08-27 04:39:51]

kouhei@chromium.org changed reviewers:
+ tasak@google.com

[kouhei (in TOK), 2015-08-27 04:40:03]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2015-08-27 04:40:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1308573006/#ps20001
(title: "Adding CORE_EXPORT per tasak@ suggestion")

[commit-bot: I haz the power, 2015-08-27 04:40:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308573006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308573006/20001

[commit-bot: I haz the power, 2015-08-27 07:27:10]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201294

[yosin_UTC9, 2015-08-27 12:50:13]

yosin@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2015-08-27 12:50:14]

https://codereview.chromium.org/1308573006/diff/20001/Source/core/html/parser...
File Source/core/html/parser/HTMLEntityParserTest.cpp (right):

https://codereview.chromium.org/1308573006/diff/20001/Source/core/html/parser...
Source/core/html/parser/HTMLEntityParserTest.cpp:24:
EXPECT_STREQ(original.ascii().data(), src.toString().ascii().data());
nit: EXPECT_EQ() can accept String. So, you can write
EXPECT_EQ(original, src.toString())

[Peter Beverloo, 2015-08-27 15:33:19]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1311043004/ by peter@chromium.org.

The reason for reverting is: HTMLEntityParserTest.ConsumeHTMLEntityIncomplete
fails on two Win bots

The newly added test is failing on WebKit Win7 (dbg) and WebKit Win Oilpan
(dbg) with the following message:

[ RUN      ] HTMLEntityParserTest.ConsumeHTMLEntityIncomplete
ASSERTION FAILED: !notEnoughCharacters

Sorry for the revert! Full output @ http://goo.gl/tnYH67.

[kouhei (in TOK), 2015-08-28 02:29:34]

On 2015/08/27 15:33:19, Peter Beverloo wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1311043004/ by mailto:peter@chromium.org.
> 
> The reason for reverting is: HTMLEntityParserTest.ConsumeHTMLEntityIncomplete
> fails on two Win bots
> 
> The newly added test is failing on WebKit Win7 (dbg) and WebKit Win Oilpan
> (dbg) with the following message:
> 
> [ RUN      ] HTMLEntityParserTest.ConsumeHTMLEntityIncomplete
> ASSERTION FAILED: !notEnoughCharacters
> 
> Sorry for the revert! Full output @ http://goo.gl/tnYH67.

Thanks for the revert. Fixed and relanding w/ PS3

[kouhei (in TOK), 2015-08-28 02:30:24]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2015-08-28 02:30:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1308573006/#ps40001
(title: "fix test / accept yosin@ suggestion")

[commit-bot: I haz the power, 2015-08-28 02:30:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308573006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308573006/40001

[commit-bot: I haz the power, 2015-08-28 04:50:12]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201369