content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1308553007: Convert MouseEvents from DIPS to Pixels before passing it to surfaces for hittesting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1308553007: Convert MouseEvents from DIPS to Pixels before passing it to surfaces for hittesting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing mac Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_aura.cc ('K') | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/site_per_process_browsertest.h » ('j') | content/browser/site_per_process_browsertest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index fb8951657c224d84ff28b942dad3ade8ec639b68..626f823e337da01e2a1a722a60ed773fa7df6b07 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1593,8 +1593,14 @@ uint32_t RenderWidgetHostViewMac::GetSurfaceIdNamespace() {

uint32_t RenderWidgetHostViewMac::SurfaceIdNamespaceAtPoint(

const gfx::Point& point,

gfx::Point* transformed_point) {

- cc::SurfaceId id =

- delegated_frame_host_->SurfaceIdAtPoint(point, transformed_point);

+ float scale_factor = gfx::Screen::GetScreenFor(cocoa_view_)

+ ->GetDisplayNearestWindow(cocoa_view_)

+ .device_scale_factor();

+ gfx::Point point_in_pixels = gfx::ConvertPointToPixel(scale_factor, point);

+ cc::SurfaceId id = delegated_frame_host_->SurfaceIdAtPoint(point_in_pixels,

+ transformed_point);

+ *transformed_point = gfx::ConvertPointToDIP(scale_factor, *transformed_point);

// It is possible that the renderer has not yet produced a surface, in which

// case we return our current namespace.

if (id.is_null())