chrome/browser/manifest/manifest_icon_selector.h - Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/manifest/manifest_icon_selector.h

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon

Patch Set: Rebase to fix merge Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/manifest/manifest_icon_downloader.cc ('K') | « chrome/browser/manifest/manifest_icon_downloader.cc ('k') | chrome/browser/manifest/manifest_icon_selector.cc » ('j') | chrome/browser/manifest/manifest_icon_selector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/manifest/manifest_icon_selector.h

diff --git a/chrome/browser/manifest/manifest_icon_selector.h b/chrome/browser/manifest/manifest_icon_selector.h

index 54ccdbab988fd72e21a94d9362f03531d3a2e28f..ff6784983c582a0224368d254cb2af8d2c0bfecd 100644

--- a/chrome/browser/manifest/manifest_icon_selector.h

+++ b/chrome/browser/manifest/manifest_icon_selector.h

@@ -33,13 +33,14 @@ class ManifestIconSelector {

// If/when this class is generalized, it may be a good idea to switch this to

// taking in pixels, instead.

- // The icon returned will have a minimum size of an image one density bucket

- // smaller than the device denisity * preferred_icon_size_in_dp.

+ // Any icon returned will have a minimum size as specified by

+ // |minimum_icon_size_in_dp|.

mlamouri (slow - plz ping) 2015/09/16 09:58:29 nit: I find the comment confusing. Maybe it could

Lalit Maganti 2015/09/16 11:45:26 Done.

// Returns the icon url if a suitable icon is found. An empty URL otherwise.

static GURL FindBestMatchingIcon(

const std::vector<content::Manifest::Icon>& icons,

int ideal_icon_size_in_dp,

+ int minimum_icon_size_in_dp,

const gfx::Screen* screen);

private: