chrome/browser/android/shortcut_helper.cc - Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.cc

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon

Patch Set: Fix compile Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/shortcut_helper.h ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h » ('j') | chrome/browser/banners/app_banner_manager_desktop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_helper.cc

diff --git a/chrome/browser/android/shortcut_helper.cc b/chrome/browser/android/shortcut_helper.cc

index cead81b0d9f22a05e0c5ef072dfd7b067508c017..1e636e568280dd053a3b13d1e2b53841d17e05f4 100644

--- a/chrome/browser/android/shortcut_helper.cc

+++ b/chrome/browser/android/shortcut_helper.cc

@@ -64,6 +64,7 @@ void ShortcutHelper::FetchSplashScreenImage(

content::WebContents* web_contents,

const GURL& image_url,

const int ideal_splash_image_size_in_dp,

+ const int minimum_splash_image_size_in_dp,

const std::string& webapp_id) {

// This is a fire and forget task. It is not vital for the splash screen image

// to be downloaded so if the downloader returns false there is no fallback.

@@ -71,6 +72,7 @@ void ShortcutHelper::FetchSplashScreenImage(

web_contents,

image_url,

ideal_splash_image_size_in_dp,

+ minimum_splash_image_size_in_dp,

base::Bind(&ShortcutHelper::StoreWebappData, webapp_id));

}