chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java - Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon

Patch Set: Fix compile Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java » ('j') | chrome/browser/banners/app_banner_manager_desktop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

index e5eb34358b32777d778d3c3d9754d26b4fde6e2e..87be3ec6ea00eadb0745076af55c59dabc2a362f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

@@ -70,8 +70,10 @@ public class AppBannerManager extends EmptyTabObserver {

public AppBannerManager(Tab tab, Context context) {

mNativePointer = nativeInit(

- ShortcutHelper.getIdealSplashImageSizeInDp(context.getResources()),

- ShortcutHelper.getIdealIconSizeInDp(context.getResources()));

+ ShortcutHelper.getIdealIconSizeInDp(context),

+ ShortcutHelper.getMinimumIconSizeInDp(context),

+ ShortcutHelper.getIdealSplashImageSizeInDp(context),

+ ShortcutHelper.getMinimumSplashImageSizeInDp(context));

mTab = tab;

updatePointers();

}

@@ -165,7 +167,8 @@ public class AppBannerManager extends EmptyTabObserver {

}

private static native boolean nativeIsEnabled();

- private native long nativeInit(int idealSplashImageSizeInDp, int idealIconSizeInDp);

+ private native long nativeInit(int idealIconSizeInDp, int minimumIconSizeInDp,

+ int idealSplashImageSizeInDp, int minimumSplashImageSizeInDp);

private native void nativeDestroy(long nativeAppBannerManagerAndroid);

private native void nativeReplaceWebContents(long nativeAppBannerManagerAndroid,

WebContents webContents);