Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1308513004: fUsesLocalCoords is updated in the parent when a child proc is registered. (Closed)

Created:
5 years, 4 months ago by wangyix
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

This code should've been part of the CL that added registerChildProcessor(); without updating fUsesLocalCoords in the parent when a child proc is registered, batching will not work properly. BUG=skia:4182 Committed: https://skia.googlesource.com/skia/+/a71170cce8831b4d1e06bd673560f8b6fea9fbfe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/gpu/GrProcessor.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
wangyix
I forgot to add this check inside registerChildProcessor(). Without this change, there will be problems ...
5 years, 4 months ago (2015-08-20 20:41:43 UTC) #2
joshualitt
On 2015/08/20 20:41:43, wangyix wrote: > I forgot to add this check inside registerChildProcessor(). Without ...
5 years, 4 months ago (2015-08-21 13:29:52 UTC) #3
tomhudson
On 2015/08/21 13:29:52, joshualitt wrote: > lgtm, please update the description Ditto.
5 years, 4 months ago (2015-08-21 13:45:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308513004/1
5 years, 4 months ago (2015-08-21 13:50:10 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 13:56:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a71170cce8831b4d1e06bd673560f8b6fea9fbfe

Powered by Google App Engine
This is Rietveld 408576698