Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1308443002: Reland of "[tracing] Add browser-side tests for memory dumps." (Closed)

Created:
5 years, 4 months ago by Ruud van Asseldonk
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "[tracing] Add browser-side tests for memory dumps." This is identical to https://crrev.com/1290103004. Once https://crrev.com/1289793007 lands the tests should no longer be flaky. Original description below: The original CL (https://crrev.com/1295753002) got reverted due to test flakiness. This was because of the memory dump manager performing a periodic memory dump. If the test completed before such a dump would be done, it would pass, but when a periodic dump happened during the test, OnMemoryDump would be called too often. The solution is to disable periodic memory dumps in tests. This needs to be done via TraceConfig in the long term, for now this is a workaround. BUG=518823, 522009, 522165 TBR=dsinclair@chromium.org Committed: https://crrev.com/6cbb92a6de7198fbf824e8b50c10ae115d789e1a Cr-Commit-Position: refs/heads/master@{#345076}

Patch Set 1 #

Patch Set 2 : Rebase onto https://crrev.com/1289793007 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -2 lines) Patch
M base/trace_event/memory_dump_manager.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
A content/browser/tracing/memory_tracing_browsertest.cc View 1 chunk +215 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Ruud van Asseldonk
Once https://crrev.com/1289793007 lands we can land this again and the flakiness should be fixed. I ...
5 years, 4 months ago (2015-08-24 12:00:14 UTC) #2
Primiano Tucci (use gerrit)
LGTM. Please keep a close eye to the build.chromium.org waterfall and sheriff-o-matic.appspot.com to see if ...
5 years, 4 months ago (2015-08-24 14:42:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308443002/20001
5 years, 4 months ago (2015-08-24 14:55:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 15:49:05 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 15:49:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cbb92a6de7198fbf824e8b50c10ae115d789e1a
Cr-Commit-Position: refs/heads/master@{#345076}

Powered by Google App Engine
This is Rietveld 408576698