pkg/analyzer/bin/formatter.dart - Issue 130843005: Fix to ensure only modified files are written to (dartbug.com/16093).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/bin/formatter.dart

Issue 130843005: Fix to ensure only modified files are written to (dartbug.com/16093). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/bin/formatter.dart

===================================================================

--- pkg/analyzer/bin/formatter.dart (revision 31858)

+++ pkg/analyzer/bin/formatter.dart (working copy)

@@ -113,7 +113,10 @@

var rawSource = file.readAsStringSync();

var formatted = _format(rawSource, CodeKind.COMPILATION_UNIT);

if (overwriteFileContents) {

- file.writeAsStringSync(formatted);

+ // Only touch files files whose contents will be changed

+ if (rawSource != formatted) {

+ file.writeAsStringSync(formatted);

+ }

} else {

print(formatted);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »