Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1308403004: Fix typo in gn ccache support for linux:x86 (Closed)

Created:
5 years, 4 months ago by tsniatowski
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, Nico, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in gn ccache support for linux:x86 BUG= Committed: https://crrev.com/0127ddc1c60d51b1925eb8b2a3740147d5d34de5 Cr-Commit-Position: refs/heads/master@{#345355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tsniatowski
5 years, 4 months ago (2015-08-25 08:10:14 UTC) #2
Nico
lgtm
5 years, 4 months ago (2015-08-25 16:29:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308403004/1
5 years, 4 months ago (2015-08-25 16:29:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 16:58:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0127ddc1c60d51b1925eb8b2a3740147d5d34de5 Cr-Commit-Position: refs/heads/master@{#345355}
5 years, 4 months ago (2015-08-25 16:58:58 UTC) #7
Dirk Pranke
5 years, 4 months ago (2015-08-25 20:01:09 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698