Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3905)

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 1308403002: [Tracing] Disable registration of regular dump providers during tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reland-content-browsertest
Patch Set: Fix RegisterDumperWhileDumping test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_manager.h
diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h
index db963111e86ddcf856e61cab91c53c48ef99d6bb..cf865f6d64edfddbecb32a286c50ed21842f0b7e 100644
--- a/base/trace_event/memory_dump_manager.h
+++ b/base/trace_event/memory_dump_manager.h
@@ -104,6 +104,15 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
return kSystemAllocatorPoolName;
};
+ // When true, calling |RegisterMemoryDumpProvider| is a no-op.
+ bool dumper_registrations_ignored_for_testing() const {
Primiano Tucci (use gerrit) 2015/10/13 13:35:50 there doesn't seem to be any use of this getter. p
Ruud van Asseldonk 2015/10/13 13:55:41 Done.
+ return dumper_registrations_ignored_for_testing_;
+ }
+
+ void set_dumper_registrations_ignored_for_testing(bool ignore) {
Primiano Tucci (use gerrit) 2015/10/13 13:35:50 s/ignore/ignored/ in the arg name
Ruud van Asseldonk 2015/10/13 13:55:41 Done.
+ dumper_registrations_ignored_for_testing_ = ignore;
+ }
+
private:
friend struct DefaultDeleter<MemoryDumpManager>; // For the testing instance.
friend struct DefaultSingletonTraits<MemoryDumpManager>;
@@ -224,8 +233,8 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
// expected to be valid only when tracing is enabled.
uint64 tracing_process_id_;
- // Skips the auto-registration of the core dumpers during Initialize().
- bool skip_core_dumpers_auto_registration_for_testing_;
+ // When true, calling |RegisterMemoryDumpProvider| is a no-op.
+ bool dumper_registrations_ignored_for_testing_;
// Whether new memory dump providers should be told to enable heap profiling.
bool heap_profiling_enabled_;
« no previous file with comments | « no previous file | base/trace_event/memory_dump_manager.cc » ('j') | base/trace_event/memory_dump_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698