Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 13084008: Revert 140817 "Web Inspector: [Styles] Editing a property value ..." (Closed)

Created:
7 years, 8 months ago by pfeldman
Modified:
7 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Revert 140817 "Web Inspector: [Styles] Editing a property value ..." BUG=225346 > Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style > https://bugs.webkit.org/show_bug.cgi?id=107936 > > Reviewed by Yury Semikhatsky. > > Source/WebCore: > > Restore the original CSS property value before editing. > > Test: inspector/styles/edit-value-with-trimmed-url.html > > * inspector/front-end/StylesSidebarPane.js: > > LayoutTests: > > * inspector/styles/edit-value-with-trimmed-url-expected.txt: Added. > * inspector/styles/edit-value-with-trimmed-url.html: Added. TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -51 lines) Patch
D LayoutTests/inspector/styles/edit-value-with-trimmed-url.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/inspector/styles/edit-value-with-trimmed-url-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/inspector/front-end/StylesSidebarPane.js View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
7 years, 8 months ago (2013-04-01 17:56:58 UTC) #1
pfeldman
7 years, 8 months ago (2013-04-01 17:58:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r147341.

Powered by Google App Engine
This is Rietveld 408576698