Issue 13084008: Revert 140817 "Web Inspector: [Styles] Editing a property value ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13084008: Revert 140817 "Web Inspector: [Styles] Editing a property value ..." (Closed)

Created:
7 years, 8 months ago by pfeldman

Modified:
7 years, 8 months ago

Reviewers:
pfeldman

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Revert 140817 "Web Inspector: [Styles] Editing a property value ..." BUG=225346 > Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style > https://bugs.webkit.org/show_bug.cgi?id=107936 > > Reviewed by Yury Semikhatsky. > > Source/WebCore: > > Restore the original CSS property value before editing. > > Test: inspector/styles/edit-value-with-trimmed-url.html > > * inspector/front-end/StylesSidebarPane.js: > > LayoutTests: > > * inspector/styles/edit-value-with-trimmed-url-expected.txt: Added. > * inspector/styles/edit-value-with-trimmed-url.html: Added. TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147341

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -51 lines)			Patch
D	LayoutTests/inspector/styles/edit-value-with-trimmed-url.html	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	LayoutTests/inspector/styles/edit-value-with-trimmed-url-expected.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/WebCore/inspector/front-end/StylesSidebarPane.js	View	1 chunk	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r147341.

Expand Messages | Collapse Messages