Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1308393003: Add a PLACEHOLDER code kind. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a PLACEHOLDER code kind. The PLACEHOLDER code kind is used when compiling a code object that has direct calls to other code objects, but those other code objects do not yet exist because they have not yet been compiled. It serves as a placeholder to break the cycle, e.g. in WASM. R=yangguo@chromium.org BUG= Committed: https://crrev.com/e4bcc3363f2db15bbc0ba57b91676ce7f1c4adb1 Cr-Commit-Position: refs/heads/master@{#30348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/log.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
titzer
5 years, 4 months ago (2015-08-24 19:51:52 UTC) #1
Yang
On 2015/08/24 19:51:52, titzer wrote: LGTM. I wonder whether we can know the code kind ...
5 years, 4 months ago (2015-08-25 09:40:14 UTC) #2
titzer
On 2015/08/25 09:40:14, Yang wrote: > On 2015/08/24 19:51:52, titzer wrote: > > LGTM. > ...
5 years, 4 months ago (2015-08-25 09:44:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308393003/1
5 years, 4 months ago (2015-08-25 10:16:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 10:17:31 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 10:17:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4bcc3363f2db15bbc0ba57b91676ce7f1c4adb1
Cr-Commit-Position: refs/heads/master@{#30348}

Powered by Google App Engine
This is Rietveld 408576698