Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1308373005: Cache String.split not found results as well (Closed)

Created:
5 years, 3 months ago by skomski
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cache String.split not found results as well Before String.split only cached results if the seperator was found BUG=v8:4191 LOG=N Committed: https://crrev.com/a5f710275462f3e1088a97eddf5c712f03a33719 Cr-Commit-Position: refs/heads/master@{#30632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/runtime/runtime-regexp.cc View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
skomski
Sorry didn't really know who to pick because yangguo is apparently OOO so I picked ...
5 years, 3 months ago (2015-09-07 09:30:48 UTC) #2
Jakob Kummerow
LGTM. Yang, is more caching something we want strategically? I wouldn't be surprised if this ...
5 years, 3 months ago (2015-09-08 09:50:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308373005/1
5 years, 3 months ago (2015-09-08 10:00:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5619)
5 years, 3 months ago (2015-09-08 10:07:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308373005/1
5 years, 3 months ago (2015-09-08 10:09:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 10:30:12 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5f710275462f3e1088a97eddf5c712f03a33719 Cr-Commit-Position: refs/heads/master@{#30632}
5 years, 3 months ago (2015-09-08 10:30:31 UTC) #11
Yang
5 years, 3 months ago (2015-09-08 21:32:26 UTC) #12
Message was sent while issue was closed.
On 2015/09/08 09:50:39, Jakob wrote:
> LGTM.
> 
> Yang, is more caching something we want strategically? I wouldn't be surprised
> if this cache were a benchmark-specific hack that we'd rather get rid of. If
you
> don't like this change, feel free to revert it.

Seems alright to me. We have this cache either way, might as well use it to the
fullest.

Powered by Google App Engine
This is Rietveld 408576698