Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1308373003: PPC: [Interpreter] Add support for parameter variables. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Add support for parameter variables. Port 5d975694e4d3ecf66716cc5395d4d10c9730f9dd Original commit message: Adds support for parameters to the BytecodeArrayBuilder and BytecodeGenerator. Parameters are accessed as negative interpreter registers. R=rmcilroy@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/ae781735b4567290d7069e14b4edb990ce81d94d Cr-Commit-Position: refs/heads/master@{#30424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-27 16:43:00 UTC) #1
JoranSiu
lgtm
5 years, 3 months ago (2015-08-27 16:48:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308373003/1
5 years, 3 months ago (2015-08-27 16:48:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 17:12:48 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 17:13:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae781735b4567290d7069e14b4edb990ce81d94d
Cr-Commit-Position: refs/heads/master@{#30424}

Powered by Google App Engine
This is Rietveld 408576698