Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/omnibox/autocomplete_controller_android.cc
diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.cc b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
index 3c82c97160592adf50367185411b5ade3370cec0..60b66837652aeb62650594a5c265733f1cec8562 100644
--- a/chrome/browser/android/omnibox/autocomplete_controller_android.cc
+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
@@ -521,12 +521,11 @@
return reinterpret_cast<intptr_t>(native_bridge);
}
-static ScopedJavaLocalRef<jstring> QualifyPartialURLQuery(JNIEnv* env,
- jclass clazz,
- jstring jquery) {
+static jstring QualifyPartialURLQuery(
+ JNIEnv* env, jclass clazz, jstring jquery) {
Profile* profile = ProfileManager::GetActiveUserProfile();
if (!profile)
- return ScopedJavaLocalRef<jstring>();
+ return NULL;
AutocompleteMatch match;
base::string16 query_string(ConvertJavaStringToUTF16(env, jquery));
AutocompleteClassifierFactory::GetForProfile(profile)->Classify(
@@ -537,16 +536,16 @@
&match,
NULL);
if (!match.destination_url.is_valid())
- return ScopedJavaLocalRef<jstring>();
+ return NULL;
// Only return a URL if the match is a URL type.
if (match.type != AutocompleteMatchType::URL_WHAT_YOU_TYPED &&
match.type != AutocompleteMatchType::HISTORY_URL &&
match.type != AutocompleteMatchType::NAVSUGGEST)
- return ScopedJavaLocalRef<jstring>();
+ return NULL;
// As we are returning to Java, it is fine to call Release().
- return ConvertUTF8ToJavaString(env, match.destination_url.spec());
+ return ConvertUTF8ToJavaString(env, match.destination_url.spec()).Release();
}
static void PrefetchZeroSuggestResults(JNIEnv* env, jclass clazz) {
« no previous file with comments | « chrome/browser/android/download/chrome_download_delegate.cc ('k') | chrome/browser/android/password_ui_view_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698