Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Unified Diff: android_webview/native/aw_contents_statics.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/android_protocol_handler.cc ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_contents_statics.cc
diff --git a/android_webview/native/aw_contents_statics.cc b/android_webview/native/aw_contents_statics.cc
index 11e39b534c225545c2250e463b12b2e3df6f5fa4..f930e3d1686d30547fb373b9ab866e77091107b5 100644
--- a/android_webview/native/aw_contents_statics.cc
+++ b/android_webview/native/aw_contents_statics.cc
@@ -77,9 +77,9 @@
}
// static
-ScopedJavaLocalRef<jstring> GetUnreachableWebDataUrl(JNIEnv* env, jclass) {
+jstring GetUnreachableWebDataUrl(JNIEnv* env, jclass) {
return base::android::ConvertUTF8ToJavaString(
- env, content::kUnreachableWebDataURL);
+ env, content::kUnreachableWebDataURL).Release();
}
// static
@@ -93,8 +93,8 @@
}
// static
-ScopedJavaLocalRef<jstring> GetProductVersion(JNIEnv* env, jclass) {
- return base::android::ConvertUTF8ToJavaString(env, PRODUCT_VERSION);
+jstring GetProductVersion(JNIEnv* env, jclass) {
+ return base::android::ConvertUTF8ToJavaString(env, PRODUCT_VERSION).Release();
}
bool RegisterAwContentsStatics(JNIEnv* env) {
« no previous file with comments | « android_webview/native/android_protocol_handler.cc ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698