base/android/jni_generator/testFromJavaP.golden - Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testFromJavaP.golden

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/jni_generator/testEagerCalledByNativesOption.golden ('k') | base/android/jni_generator/testNativeExportsOption.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/jni_generator/testFromJavaP.golden

diff --git a/base/android/jni_generator/testFromJavaP.golden b/base/android/jni_generator/testFromJavaP.golden

index f32666c252960a8b1fac7993dc854cb328f54255..b7276bc29383d5c623975bef5f75057c2943af6a 100644

--- a/base/android/jni_generator/testFromJavaP.golden

+++ b/base/android/jni_generator/testFromJavaP.golden

@@ -230,9 +230,10 @@

}

static base::subtle::AtomicWord g_InputStream_Constructor = 0;

-static ScopedJavaLocalRef<jobject> Java_InputStream_Constructor(JNIEnv* env)

- __attribute__ ((unused));

-static ScopedJavaLocalRef<jobject> Java_InputStream_Constructor(JNIEnv* env) {

+static base::android::ScopedJavaLocalRef<jobject>

+ Java_InputStream_Constructor(JNIEnv* env) __attribute__ ((unused));

+static base::android::ScopedJavaLocalRef<jobject>

+ Java_InputStream_Constructor(JNIEnv* env) {

/* Must call RegisterNativesImpl() */

CHECK_CLAZZ(env, InputStream_clazz(env),

InputStream_clazz(env), NULL);

@@ -248,7 +249,7 @@

env->NewObject(InputStream_clazz(env),

method_id);

jni_generator::CheckException(env);

- return ScopedJavaLocalRef<jobject>(env, ret);

+ return base::android::ScopedJavaLocalRef<jobject>(env, ret);

}

// Step 3: RegisterNatives.