Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: sync/android/model_type_helper.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/jni/chromoting_jni_runtime.cc ('k') | ui/base/l10n/l10n_util_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/android/model_type_helper.cc
diff --git a/sync/android/model_type_helper.cc b/sync/android/model_type_helper.cc
index 37650cbdf39d102912717103656e357846c34f4c..6d30eaa6d03f171807959970aa628d65f22876b9 100644
--- a/sync/android/model_type_helper.cc
+++ b/sync/android/model_type_helper.cc
@@ -11,14 +11,16 @@
namespace syncer {
-static ScopedJavaLocalRef<jstring>
-ModelTypeToNotificationType(JNIEnv* env, jclass clazz, jint model_type_int) {
+static jstring ModelTypeToNotificationType(JNIEnv* env,
+ jclass clazz,
+ jint model_type_int) {
std::string model_type_string;
ModelType model_type = static_cast<ModelType>(model_type_int);
if (!RealModelTypeToNotificationType(model_type, &model_type_string)) {
NOTREACHED() << "No string representation of model type " << model_type;
}
- return base::android::ConvertUTF8ToJavaString(env, model_type_string);
+ return base::android::ConvertUTF8ToJavaString(env, model_type_string)
+ .Release();
}
bool RegisterModelTypeHelperJni(JNIEnv* env) {
« no previous file with comments | « remoting/client/jni/chromoting_jni_runtime.cc ('k') | ui/base/l10n/l10n_util_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698