Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: content/browser/android/content_view_statics.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_statics.cc
diff --git a/content/browser/android/content_view_statics.cc b/content/browser/android/content_view_statics.cc
index 6040e643442704d326feefbd925d60f59b3ebecb..e0f26a0fff88a5a85e4ed8192d10fc41d3bbaf51 100644
--- a/content/browser/android/content_view_statics.cc
+++ b/content/browser/android/content_view_statics.cc
@@ -96,14 +96,12 @@
} // namespace
// Returns the first substring consisting of the address of a physical location.
-static ScopedJavaLocalRef<jstring> FindAddress(JNIEnv* env,
- jclass clazz,
- jstring addr) {
+static jstring FindAddress(JNIEnv* env, jclass clazz, jstring addr) {
base::string16 content_16 = ConvertJavaStringToUTF16(env, addr);
base::string16 result_16;
if (content::address_parser::FindAddress(content_16, &result_16))
- return ConvertUTF16ToJavaString(env, result_16);
- return ScopedJavaLocalRef<jstring>();
+ return ConvertUTF16ToJavaString(env, result_16).Release();
+ return NULL;
}
static void SetWebKitSharedTimersSuspended(JNIEnv* env,
« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/android/tracing_controller_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698