android_webview/native/cookie_manager.cc - Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/cookie_manager.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/cookie_manager.cc

diff --git a/android_webview/native/cookie_manager.cc b/android_webview/native/cookie_manager.cc

index 130e76c853098d1085ec5100c31d8f5f6ec74dd3..b7243bd8544c54b13cf2fa3fb309a9942c3180d2 100644

--- a/android_webview/native/cookie_manager.cc

+++ b/android_webview/native/cookie_manager.cc

@@ -542,13 +542,12 @@

CookieManager::GetInstance()->SetCookieSync(host, cookie_value);

}

-static ScopedJavaLocalRef<jstring> GetCookie(JNIEnv* env,

- jobject obj,

- jstring url) {

+static jstring GetCookie(JNIEnv* env, jobject obj, jstring url) {

GURL host(ConvertJavaStringToUTF16(env, url));

return base::android::ConvertUTF8ToJavaString(

- env, CookieManager::GetInstance()->GetCookie(host));

+ env,

+ CookieManager::GetInstance()->GetCookie(host)).Release();

}

static void RemoveSessionCookies(JNIEnv* env,

« no previous file with comments | « android_webview/native/aw_settings.cc ('k') | base/android/command_line_android.cc » ('j') | no next file with comments »