Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Side by Side Diff: components/dom_distiller/core/url_utils_android.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/dom_distiller/core/url_utils_android.h" 5 #include "components/dom_distiller/core/url_utils_android.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "components/dom_distiller/core/url_constants.h" 10 #include "components/dom_distiller/core/url_constants.h"
11 #include "components/dom_distiller/core/url_utils.h" 11 #include "components/dom_distiller/core/url_utils.h"
12 #include "jni/DomDistillerUrlUtils_jni.h" 12 #include "jni/DomDistillerUrlUtils_jni.h"
13 #include "net/base/url_util.h" 13 #include "net/base/url_util.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 15
16 namespace dom_distiller { 16 namespace dom_distiller {
17 17
18 namespace url_utils { 18 namespace url_utils {
19 19
20 namespace android { 20 namespace android {
21 21
22 ScopedJavaLocalRef<jstring> GetDistillerViewUrlFromUrl(JNIEnv* env, 22 jstring GetDistillerViewUrlFromUrl(JNIEnv* env,
23 jclass clazz, 23 jclass clazz,
24 jstring j_scheme, 24 jstring j_scheme,
25 jstring j_url) { 25 jstring j_url) {
26 std::string scheme(base::android::ConvertJavaStringToUTF8(env, j_scheme)); 26 std::string scheme(base::android::ConvertJavaStringToUTF8(env, j_scheme));
27 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url)); 27 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url));
28 if (!url.is_valid()) { 28 if (!url.is_valid()) {
29 return ScopedJavaLocalRef<jstring>(); 29 return NULL;
30 } 30 }
31 GURL view_url = 31 GURL view_url =
32 dom_distiller::url_utils::GetDistillerViewUrlFromUrl(scheme, url); 32 dom_distiller::url_utils::GetDistillerViewUrlFromUrl(scheme, url);
33 if (!view_url.is_valid()) { 33 if (!view_url.is_valid()) {
34 return ScopedJavaLocalRef<jstring>(); 34 return NULL;
35 } 35 }
36 return base::android::ConvertUTF8ToJavaString(env, view_url.spec()); 36 return base::android::ConvertUTF8ToJavaString(env, view_url.spec()).Release();
37 } 37 }
38 38
39 ScopedJavaLocalRef<jstring> GetOriginalUrlFromDistillerUrl(JNIEnv* env, 39 jstring GetOriginalUrlFromDistillerUrl(JNIEnv* env,
40 jclass clazz, 40 jclass clazz,
41 jstring j_url) { 41 jstring j_url) {
42 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url)); 42 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url));
43 if (!url.is_valid()) 43 if (!url.is_valid())
44 return ScopedJavaLocalRef<jstring>(); 44 return NULL;
45 45
46 GURL original_url = 46 GURL original_url =
47 dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(url); 47 dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(url);
48 if (!original_url.is_valid()) 48 if (!original_url.is_valid())
49 return ScopedJavaLocalRef<jstring>(); 49 return NULL;
50 50
51 return base::android::ConvertUTF8ToJavaString(env, original_url.spec()); 51 return base::android::ConvertUTF8ToJavaString(env, original_url.spec())
52 .Release();
52 } 53 }
53 54
54 jboolean IsDistilledPage(JNIEnv* env, jclass clazz, jstring j_url) { 55 jboolean IsDistilledPage(JNIEnv* env, jclass clazz, jstring j_url) {
55 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url)); 56 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url));
56 return dom_distiller::url_utils::IsDistilledPage(url); 57 return dom_distiller::url_utils::IsDistilledPage(url);
57 } 58 }
58 59
59 jboolean IsUrlDistillable(JNIEnv* env, jclass clazz, jstring j_url) { 60 jboolean IsUrlDistillable(JNIEnv* env, jclass clazz, jstring j_url) {
60 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url)); 61 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url));
61 return dom_distiller::url_utils::IsUrlDistillable(url); 62 return dom_distiller::url_utils::IsUrlDistillable(url);
62 } 63 }
63 64
64 ScopedJavaLocalRef<jstring> GetIsDistillableJs(JNIEnv* env, jclass clazz) { 65 jstring GetIsDistillableJs(JNIEnv* env, jclass clazz) {
65 return base::android::ConvertUTF8ToJavaString( 66 return base::android::ConvertUTF8ToJavaString(
66 env, dom_distiller::url_utils::GetIsDistillableJs()); 67 env, dom_distiller::url_utils::GetIsDistillableJs()).Release();
67 } 68 }
68 69
69 ScopedJavaLocalRef<jstring> GetValueForKeyInUrl(JNIEnv* env, 70 jstring GetValueForKeyInUrl(JNIEnv* env,
70 jclass clazz, 71 jclass clazz,
71 jstring j_url, 72 jstring j_url,
72 jstring j_key) { 73 jstring j_key) {
73 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url)); 74 GURL url(base::android::ConvertJavaStringToUTF8(env, j_url));
74 std::string key = base::android::ConvertJavaStringToUTF8(env, j_key); 75 std::string key = base::android::ConvertJavaStringToUTF8(env, j_key);
75 return base::android::ConvertUTF8ToJavaString( 76 return base::android::
76 env, dom_distiller::url_utils::GetValueForKeyInUrl(url, key)); 77 ConvertUTF8ToJavaString(
78 env, dom_distiller::url_utils::GetValueForKeyInUrl(url, key))
79 .Release();
77 } 80 }
78 81
79 bool RegisterUrlUtils(JNIEnv* env) { return RegisterNativesImpl(env); } 82 bool RegisterUrlUtils(JNIEnv* env) { return RegisterNativesImpl(env); }
80 83
81 } // namespace android 84 } // namespace android
82 85
83 } // namespace url_utils 86 } // namespace url_utils
84 87
85 } // namespace dom_distiller 88 } // namespace dom_distiller
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698