Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 130833002: Revert 243777 "Moves CandidateWindow model to ui/base/ime." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc
===================================================================
--- trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc (revision 243783)
+++ trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc (working copy)
@@ -20,6 +20,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
+#include "chromeos/ime/candidate_window.h"
#include "chromeos/ime/component_extension_ime_manager.h"
#include "chromeos/ime/extension_ime_util.h"
#include "chromeos/ime/ibus_keymap.h"
@@ -27,7 +28,6 @@
#include "chromeos/ime/input_method_manager.h"
#include "ui/aura/root_window.h"
#include "ui/aura/window.h"
-#include "ui/base/ime/candidate_window.h"
#include "ui/events/event.h"
#include "ui/events/keycodes/dom4/keycode_converter.h"
#include "ui/events/keycodes/keyboard_code_conversion_x.h"
@@ -61,7 +61,7 @@
observer_(NULL),
preedit_text_(new IBusText()),
preedit_cursor_(0),
- candidate_window_(new ui::CandidateWindow()),
+ candidate_window_(new input_method::CandidateWindow()),
window_visible_(false) {}
InputMethodEngine::~InputMethodEngine() {
@@ -254,7 +254,7 @@
const CandidateWindowProperty& property) {
// Type conversion from InputMethodEngineInterface::CandidateWindowProperty to
// CandidateWindow::CandidateWindowProperty defined in chromeos/ime/.
- ui::CandidateWindow::CandidateWindowProperty dest_property;
+ input_method::CandidateWindow::CandidateWindowProperty dest_property;
dest_property.page_size = property.page_size;
dest_property.is_cursor_visible = property.is_cursor_visible;
dest_property.is_vertical = property.is_vertical;
@@ -310,7 +310,7 @@
candidate_window_->mutable_candidates()->clear();
for (std::vector<Candidate>::const_iterator ix = candidates.begin();
ix != candidates.end(); ++ix) {
- ui::CandidateWindow::Entry entry;
+ input_method::CandidateWindow::Entry entry;
entry.value = ix->value;
entry.label = ix->label;
entry.annotation = ix->annotation;

Powered by Google App Engine
This is Rietveld 408576698