Issue 1308323012: Fix code relying on undocumented SimpleAtoi quirk, which caused rollback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1308323012: Fix code relying on undocumented SimpleAtoi quirk, which caused rollback (Closed)

Created:
5 years, 3 months ago by ramant (doing other things)

Modified:
5 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@clang_tidy_101595102

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix code relying on undocumented SimpleAtoi quirk, which caused rollback of cl/101239633. The quirk was that if an input contained null byte, everything past this byte would be silently ignored; this behavior will soon be removed. relnote: n/a (only affects tests) passes with strings change patched in. Ported this server side change to keep code similar to internal code. Merge internal change: 101605155 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	net/tools/quic/quic_spdy_server_stream.cc	View		2 chunks	+12 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 1321663007 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages