Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 1308323004: Introduce absoluteCaretBoundsOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-28T19:12:35 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/GranularityStrategyTest.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h
index d0a4d776bfdb4c053d2d75cee562797e70c3d422..0ed2f100a88bbe52c225d3e8532c81fe216d28aa 100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -112,8 +112,6 @@ public:
// Rect is local to the returned layoutObject
LayoutRect localCaretRect(LayoutObject*&) const;
- // Bounds of (possibly transformed) caret in absolute coords
- IntRect absoluteCaretBounds() const;
DECLARE_TRACE();
@@ -134,6 +132,10 @@ private:
TextAffinity m_affinity;
};
+// TODO(yosin) We should move |absoluteCaretBoundsOf()| to "VisibleUnits.cpp".
+// Bounds of (possibly transformed) caret in absolute coords
+CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&);
+
// Abs x/y position of the caret ignoring transforms.
// TODO(yosin) navigation with transforms should be smarter.
// TODO(yosin) We should move a glboal funciton
« no previous file with comments | « Source/core/editing/GranularityStrategyTest.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698