Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 1308313008: Fix ReadPixels implementation specific read format/type on desktop GL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clear
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index cad0c00a7a02bbb94be515703d95eaa1f87b4185..c960b1ef97d8de4df8456b2a8751e430c3bb1954 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -1508,12 +1508,13 @@ _NAMED_TYPE_INFO = {
'GL_RGBA',
],
'valid_es3': [
+ 'GL_RED',
+ 'GL_RED_INTEGER',
+ 'GL_RG',
+ 'GL_RG_INTEGER',
+ 'GL_RGB_INTEGER',
'GL_RGBA_INTEGER',
],
- 'deprecated_es3': [
- 'GL_ALPHA',
- 'GL_RGB',
- ],
},
'PixelType': {
'type': 'GLenum',
@@ -1600,20 +1601,16 @@ _NAMED_TYPE_INFO = {
'GL_UNSIGNED_SHORT_4_4_4_4',
'GL_UNSIGNED_SHORT_5_5_5_1',
],
- 'invalid': [
- 'GL_SHORT',
- ],
'valid_es3': [
+ 'GL_BYTE',
+ 'GL_UNSIGNED_SHORT',
+ 'GL_SHORT',
'GL_UNSIGNED_INT',
'GL_INT',
+ 'GL_HALF_FLOAT',
'GL_FLOAT',
'GL_UNSIGNED_INT_2_10_10_10_REV',
],
- 'deprecated_es3': [
- 'GL_UNSIGNED_SHORT_5_6_5',
- 'GL_UNSIGNED_SHORT_4_4_4_4',
- 'GL_UNSIGNED_SHORT_5_5_5_1',
- ],
},
'RenderBufferFormat': {
'type': 'GLenum',
« no previous file with comments | « no previous file | gpu/command_buffer/common/gles2_cmd_utils.h » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698