gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h - Issue 1308313008: Fix ReadPixels implementation specific read format/type on desktop GL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h

Issue 1308313008: Fix ReadPixels implementation specific read format/type on desktop GL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clear

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/common/gles2_cmd_utils.cc ('K') | « gpu/command_buffer/common/gles2_cmd_utils.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h

diff --git a/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h b/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h

index 0196461dc5af4da18e23455dbbabcc724b9969de..5af6462f8671810678d5dcf3ed4b81bb203af976 100644

--- a/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h

+++ b/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h

@@ -4175,7 +4175,14 @@ std::string GLES2Util::GetStringReadPixelFormat(uint32_t value) {

{GL_ALPHA, "GL_ALPHA"},

{GL_RGB, "GL_RGB"},

{GL_RGBA, "GL_RGBA"},

+ {GL_RED, "GL_RED"},

+ {GL_RED_INTEGER, "GL_RED_INTEGER"},

+ {GL_RG, "GL_RG"},

+ {GL_RG_INTEGER, "GL_RG_INTEGER"},

+ {GL_RGB_INTEGER, "GL_RGB_INTEGER"},

{GL_RGBA_INTEGER, "GL_RGBA_INTEGER"},

+ {GL_LUMINANCE, "GL_LUMINANCE"},

+ {GL_LUMINANCE_ALPHA, "GL_LUMINANCE_ALPHA"},

};

return GLES2Util::GetQualifiedEnumString(string_table,

arraysize(string_table), value);

@@ -4187,8 +4194,12 @@ std::string GLES2Util::GetStringReadPixelType(uint32_t value) {

{GL_UNSIGNED_SHORT_5_6_5, "GL_UNSIGNED_SHORT_5_6_5"},

{GL_UNSIGNED_SHORT_4_4_4_4, "GL_UNSIGNED_SHORT_4_4_4_4"},

{GL_UNSIGNED_SHORT_5_5_5_1, "GL_UNSIGNED_SHORT_5_5_5_1"},

+ {GL_BYTE, "GL_BYTE"},

+ {GL_UNSIGNED_SHORT, "GL_UNSIGNED_SHORT"},

+ {GL_SHORT, "GL_SHORT"},

{GL_UNSIGNED_INT, "GL_UNSIGNED_INT"},

{GL_INT, "GL_INT"},

+ {GL_HALF_FLOAT, "GL_HALF_FLOAT"},

{GL_FLOAT, "GL_FLOAT"},

{GL_UNSIGNED_INT_2_10_10_10_REV, "GL_UNSIGNED_INT_2_10_10_10_REV"},

};