Componentize chrome/common/sync_util

Componentize chrome/common/sync_util

The file chrome/common/sync_util.cc/h and chrome/common/sync_util_unittest.cc moved to
components/sync_driver/.

Moved switches::kSyncServiceURL new file components/sync_driver/sync_driver_switch.cc.

Added extra param version_info::Channel to
--  GetSyncServiceURL ()
--  MakeDesktopUserAgentForSync()
--  MakeUserAgentForSync ()

BUG=519578
Committed: https://crrev.com/182ef6426121e2e7c48d75a2c1a96af5ab002f3c
Cr-Commit-Position: refs/heads/master@{#346600}

[Jitu( very slow this week), 2015-08-25 06:30:21]

Patchset #1 (id:1) has been deleted

[Jitu( very slow this week), 2015-08-25 09:30:27]

Patchset #1 (id:20001) has been deleted

[Jitu( very slow this week), 2015-08-25 10:47:24]

jitendra.ks@samsung.com changed reviewers:
+ droger@chromium.org, vivekg@chromium.org

[Jitu( very slow this week), 2015-08-25 10:47:25]

PTAL !

[droger, 2015-08-25 11:25:44]

lgtm

https://codereview.chromium.org/1308313003/diff/60001/components/sync_driver/...
File components/sync_driver/sync_util.cc (right):

https://codereview.chromium.org/1308313003/diff/60001/components/sync_driver/...
components/sync_driver/sync_util.cc:9: //#include "chrome/common/channel_info.h"
Delete this line.

https://codereview.chromium.org/1308313003/diff/60001/components/sync_driver/...
components/sync_driver/sync_util.cc:16: std::string
ChannelToString(version_info::Channel channel) {
Delete this function and use version_info::GetChannelString() instead (it does
the same thing).

[Jitu( very slow this week), 2015-08-25 11:39:57]

PTAL !

https://codereview.chromium.org/1308313003/diff/60001/components/sync_driver/...
File components/sync_driver/sync_util.cc (right):

https://codereview.chromium.org/1308313003/diff/60001/components/sync_driver/...
components/sync_driver/sync_util.cc:9: //#include "chrome/common/channel_info.h"
On 2015/08/25 11:25:43, droger wrote:
> Delete this line.

Done.

https://codereview.chromium.org/1308313003/diff/60001/components/sync_driver/...
components/sync_driver/sync_util.cc:16: std::string
ChannelToString(version_info::Channel channel) {
On 2015/08/25 11:25:43, droger wrote:
> Delete this function and use version_info::GetChannelString() instead (it does
> the same thing).

Done.

[Jitu( very slow this week), 2015-08-25 11:43:17]

jitendra.ks@samsung.com changed reviewers:
+ zea@chromium.org

[Jitu( very slow this week), 2015-08-25 11:43:18]

Dear Zea,

Please do the owner review for below files
--- components/sync_driver/*

[Jitu( very slow this week), 2015-08-25 11:46:23]

On 2015/08/25 11:43:18, jitu wrote:
> Dear Zea,
> 
> Please do the owner review for below files
> --- components/sync_driver/*

Please do the owner review for all the sync files.

[droger, 2015-08-25 11:54:13]

https://codereview.chromium.org/1308313003/diff/80001/components/sync_driver/...
File components/sync_driver/sync_util.cc (right):

https://codereview.chromium.org/1308313003/diff/80001/components/sync_driver/...
components/sync_driver/sync_util.cc:75: user_agent += " channel(" +
GetChannelString(channel) + ")";
I think you need the version_info:: namespace here:
version_info::GetChannelString(channel)

[Jitu( very slow this week), 2015-08-25 13:03:48]

PTAL !

https://codereview.chromium.org/1308313003/diff/80001/components/sync_driver/...
File components/sync_driver/sync_util.cc (right):

https://codereview.chromium.org/1308313003/diff/80001/components/sync_driver/...
components/sync_driver/sync_util.cc:75: user_agent += " channel(" +
GetChannelString(channel) + ")";
On 2015/08/25 11:54:13, droger wrote:
> I think you need the version_info:: namespace here:
> version_info::GetChannelString(channel)
> 

Done.

[Nicolas Zea, 2015-08-27 18:16:16]

Mostly LG with a couple nits and a question

https://codereview.chromium.org/1308313003/diff/110001/chrome/browser/service...
File chrome/browser/services/gcm/gcm_desktop_utils.cc (right):

https://codereview.chromium.org/1308313003/diff/110001/chrome/browser/service...
chrome/browser/services/gcm/gcm_desktop_utils.cc:104:
content::BrowserThread::UI),
Did clang-format do this? Looks odd

https://codereview.chromium.org/1308313003/diff/110001/chrome/common/chrome_s...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1308313003/diff/110001/chrome/common/chrome_s...
chrome/common/chrome_switches.h:297: extern const char
kSyncShortInitialRetryOverride[];
Would it be straightforward to go ahead and move all these other kSync* switches
into sync_driver_switches? If not that's fine, it doesn't need to be in this
patch.

https://codereview.chromium.org/1308313003/diff/110001/components/sync_driver...
File components/sync_driver/sync_driver_switches.h (right):

https://codereview.chromium.org/1308313003/diff/110001/components/sync_driver...
components/sync_driver/sync_driver_switches.h:14: extern const char
kSyncServiceURL[];
nit: newline after

https://codereview.chromium.org/1308313003/diff/110001/components/sync_driver...
components/sync_driver/sync_driver_switches.h:15: }
nit: add namespace comment:
}  // namespace switches

[Jitu( very slow this week), 2015-08-28 05:52:43]

PTAL

https://codereview.chromium.org/1308313003/diff/110001/chrome/browser/service...
File chrome/browser/services/gcm/gcm_desktop_utils.cc (right):

https://codereview.chromium.org/1308313003/diff/110001/chrome/browser/service...
chrome/browser/services/gcm/gcm_desktop_utils.cc:104:
content::BrowserThread::UI),
On 2015/08/27 18:16:16, Nicolas Zea wrote:
> Did clang-format do this? Looks odd

Yes, 

Done

https://codereview.chromium.org/1308313003/diff/110001/chrome/common/chrome_s...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1308313003/diff/110001/chrome/common/chrome_s...
chrome/common/chrome_switches.h:297: extern const char
kSyncShortInitialRetryOverride[];
On 2015/08/27 18:16:16, Nicolas Zea wrote:
> Would it be straightforward to go ahead and move all these other kSync*
switches
> into sync_driver_switches? If not that's fine, it doesn't need to be in this
> patch.

Done

https://codereview.chromium.org/1308313003/diff/110001/components/sync_driver...
File components/sync_driver/sync_driver_switches.h (right):

https://codereview.chromium.org/1308313003/diff/110001/components/sync_driver...
components/sync_driver/sync_driver_switches.h:14: extern const char
kSyncServiceURL[];
On 2015/08/27 18:16:16, Nicolas Zea wrote:
> nit: newline after

Done.

https://codereview.chromium.org/1308313003/diff/110001/components/sync_driver...
components/sync_driver/sync_driver_switches.h:15: }
On 2015/08/27 18:16:16, Nicolas Zea wrote:
> nit: add namespace comment:
> }  // namespace switches

Done.

[Nicolas Zea, 2015-08-28 17:52:54]

LGTM, thanks!

[Jitu( very slow this week), 2015-08-31 05:07:36]

The CQ bit was checked by jitendra.ks@samsung.com

[Jitu( very slow this week), 2015-08-31 05:07:36]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1308313003/#ps130001
(title: "Moved all kSync* switches to sync_driver_switches")

[commit-bot: I haz the power, 2015-08-31 05:07:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308313003/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308313003/130001

[commit-bot: I haz the power, 2015-08-31 05:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 05:09:19]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Jitu( very slow this week), 2015-08-31 06:20:56]

jitendra.ks@samsung.com changed reviewers:
+ thestig@chromium.org

[Jitu( very slow this week), 2015-08-31 06:20:57]

@Lei Zhang,

Please do owner review for below files
  -- chrome/common/*

[Lei Zhang, 2015-08-31 06:53:18]

On 2015/08/31 06:20:57, jitu wrote:
> @Lei Zhang,
> 
> Please do owner review for below files
>   -- chrome/common/*

Looks ok, but you should get your CL in a state that can pass the trybots.

[Jitu( very slow this week), 2015-08-31 07:31:04]

On 2015/08/31 06:53:18, Lei Zhang wrote:
> On 2015/08/31 06:20:57, jitu wrote:
> > @Lei Zhang,
> > 
> > Please do owner review for below files
> >   -- chrome/common/*
> 
> Looks ok, but you should get your CL in a state that can pass the trybots.

Rebase issue. I ll fix and upload

[Jitu( very slow this week), 2015-08-31 12:29:19]

Patchset #7 (id:150001) has been deleted

[Jitu( very slow this week), 2015-08-31 16:46:34]

Dear Lei Zhang,

PTAL ...

[Lei Zhang, 2015-08-31 18:19:51]

lgtm

[Jitu( very slow this week), 2015-09-01 08:32:52]

The CQ bit was checked by jitendra.ks@samsung.com

[Jitu( very slow this week), 2015-09-01 08:32:52]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1308313003/#ps170001
(title: "Rebased")

[commit-bot: I haz the power, 2015-09-01 08:33:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308313003/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308313003/170001

[commit-bot: I haz the power, 2015-09-01 08:38:13]

Committed patchset #7 (id:170001)

[commit-bot: I haz the power, 2015-09-01 08:38:51]

Patchset 7 (id:??) landed as
https://crrev.com/182ef6426121e2e7c48d75a2c1a96af5ab002f3c
Cr-Commit-Position: refs/heads/master@{#346600}