Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 13083002: GDBJIT: Make GDBJIT interface compile for OSX again. (Closed)

Created:
7 years, 9 months ago by haitao.feng
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

GDBJIT: Make GDBJIT interface compile for OSX again.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/gdb-jit.cc View 1 2 3 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
I built gdb 7.4 from http://ftp.gnu.org/gnu/gdb/ on Mac OSX 10.7.5. With this CL, gdbjit compiles ...
7 years, 9 months ago (2013-03-26 06:48:27 UTC) #1
Vyacheslav Egorov (Google)
gdb-jit parts LGTM, but I don't know if we still accept any changes to SConstruct ...
7 years, 9 months ago (2013-03-26 11:28:36 UTC) #2
Jakob Kummerow
All Scons-related files in our repository are awaiting removal, there's no point in making any ...
7 years, 9 months ago (2013-03-26 12:02:37 UTC) #3
haitao.feng
I figured out the difference between gyp and scons. Scons links all the obj files ...
7 years, 9 months ago (2013-03-27 07:59:31 UTC) #4
haitao.feng
7 years, 8 months ago (2013-04-10 09:11:50 UTC) #5
Dropped the code modification to src/SConscipt as scons is going to die.

Though gdb-jit compiles for Mac with gyp, it might not work properly like on
Linux. We need to debug into gdb to understand the reason.

Powered by Google App Engine
This is Rietveld 408576698