chrome/chrome_browser_ui.gypi - Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor

Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index e26bdb3b07ffa10fe66274717487179e4f8e8a8d..ebccfff39794c3d802e68efd3960f2971df7b0d4 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -128,6 +128,7 @@

'browser/ui/bookmarks/bookmark_bar_constants.h',

'browser/ui/bookmarks/bookmark_bar_instructions_delegate.h',

'browser/ui/bookmarks/bookmark_bubble_delegate.h',

+ 'browser/ui/bookmarks/bookmark_bubble_observer.h',

'browser/ui/bookmarks/bookmark_editor.cc',

'browser/ui/bookmarks/bookmark_editor.h',

'browser/ui/bookmarks/bookmark_tab_helper.cc',

@@ -850,6 +851,8 @@

'browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm',

'browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h',

'browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm',

+ 'browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.h',

+ 'browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm',

'browser/ui/cocoa/bookmarks/bookmark_button.h',

'browser/ui/cocoa/bookmarks/bookmark_button.mm',

'browser/ui/cocoa/bookmarks/bookmark_button_cell.h',

@@ -2068,7 +2071,6 @@

'browser/ui/views/bookmarks/bookmark_bar_view_observer.h',

'browser/ui/views/bookmarks/bookmark_bubble_view.cc',

'browser/ui/views/bookmarks/bookmark_bubble_view.h',

- 'browser/ui/views/bookmarks/bookmark_bubble_view_observer.h',

'browser/ui/views/bookmarks/bookmark_context_menu.cc',

'browser/ui/views/bookmarks/bookmark_context_menu.h',

'browser/ui/views/bookmarks/bookmark_drag_drop_views.cc',

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view_observer.h ('k') | no next file » | no next file with comments »