Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor
Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
index b5dd2b1d84923d5572061a37461f703da0727e67..e1a0957b2ea463a70e2cab67d16161b3d3f971ee 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
@@ -16,7 +16,7 @@
#include "chrome/browser/bookmarks/bookmark_stats.h"
#include "chrome/browser/ui/bookmarks/bookmark_bar.h"
#include "chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h"
-#include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view_observer.h"
+#include "chrome/browser/ui/bookmarks/bookmark_bubble_observer.h"
#include "chrome/browser/ui/views/bookmarks/bookmark_menu_controller_observer.h"
#include "components/bookmarks/browser/bookmark_model_observer.h"
#include "components/bookmarks/browser/bookmark_node_data.h"
@@ -71,7 +71,7 @@ class BookmarkBarView : public views::AccessiblePaneView,
public gfx::AnimationDelegate,
public BookmarkMenuControllerObserver,
public BookmarkBarInstructionsDelegate,
- public BookmarkBubbleViewObserver {
+ public bookmarks::BookmarkBubbleObserver {
public:
// The internal view class name.
static const char kViewClassName[];
@@ -203,8 +203,8 @@ class BookmarkBarView : public views::AccessiblePaneView,
// BookmarkBarInstructionsDelegate:
void OnImportBookmarks() override;
- // BookmarkBubbleViewObserver:
- void OnBookmarkBubbleShown(const GURL& url) override;
+ // bookmarks::BookmarkBubbleObserver:
+ void OnBookmarkBubbleShown(const bookmarks::BookmarkNode* node) override;
void OnBookmarkBubbleHidden() override;
// bookmarks::BookmarkModelObserver:
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698