[Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
index 88ee2858380779f32c1dd752cdb08d515a87c01a..d72d7c98ad91bb5f9a85d2ead412e8578310b4ba 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
@@ -24,8 +24,9 @@
 @class BookmarkBarFolderController;
 @class BookmarkBarView;
 @class BookmarkButtonCell;
-@class BookmarkFolderTarget;
 @class BookmarkContextMenuCocoaController;

[tapted, 2015/08/25 01:13:20]

is this used here?

[jackhou1, 2015/08/25 04:32:29]

Yup, I was just rearranging to fix the order.

+@class BookmarkFolderTarget;
+class BookmarkModelObserverForCocoa;
 class Browser;
 class GURL;
 namespace ui {
@@ -286,6 +287,15 @@ willAnimateFromState:(BookmarkBar::State)oldState
   // Controller responsible for all bookmark context menus.
   base::scoped_nsobject<BookmarkContextMenuCocoaController>
       contextMenuController_;
+
+  // Weak pointer to the pulsed button for the currently pulsing node. We need
+  // to store this as it may not be possible to determine the pulsing button if
+  // the pulsing node is deleted. Nil if there is no pulsing node.
+  BookmarkButton* pulsingButton_;

[tapted, 2015/08/25 01:13:20]

(maybe move this to be a member of BookmarkModelObserverForCocoa)

But also I don't think it should be weak -- typically weak pointers to NSObject
are only chosen over scoped_nsobject if the latter would create a cycle.

[jackhou1, 2015/08/25 04:32:29]

I don't think this fits well in BookmarkModelObserverForCocoa (not to be
confused with BookmarkBubbleObserverCocoa). Also it would expose pulsing logic
to something outside of BookmarkBarController, which I was hoping wouldn't be
necessary. At the moment BookmarkBarController just exposes two methods.

[tapted, 2015/08/25 05:46:34]

Acknowledged.

+
+  // Specifically watch the currently pulsing node. This lets us stop pulsing
+  // when anything happens to the node. Null if there is no pulsing node.
+  scoped_ptr<BookmarkModelObserverForCocoa> pulsingBookmarkObserver_;
 }
 
 @property(readonly, nonatomic) BookmarkBar::State currentState;
@@ -308,6 +318,12 @@ willAnimateFromState:(BookmarkBar::State)oldState
 // The controller for all bookmark bar context menus.
 - (BookmarkContextMenuCocoaController*)menuController;
 
+// Pulses the given bookmark node, or the closest parent node that is visible.
+- (void)startPulsingBookmarkNode:(const bookmarks::BookmarkNode*)node;
+
+// Stops pulsing any bookmark nodes.
+- (void)stopPulsingBookmarkNode;
+
 // Updates the bookmark bar (from its current, possibly in-transition) state to
 // the new state.
 - (void)updateState:(BookmarkBar::State)newState