third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h - Issue 1308273010: Adapt and reland old position sticky implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make sticky vertical ref tests expectations not dependent on font size. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h b/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h

index 85a7efb43e22d7f1ee60c61d86e7a808948f87a7..6b4350d37d1527ac6720f1f42a5b8a2c4b37cc19 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h

@@ -51,6 +51,7 @@ struct LayoutGeometryMapStep {

: m_layoutObject(o.m_layoutObject)

, m_offset(o.m_offset)

, m_offsetForFixedPosition(o.m_offsetForFixedPosition)

+ , m_offsetForStickyPosition(o.m_offsetForStickyPosition)

, m_flags(o.m_flags)

{

ASSERT(!o.m_transform);

@@ -63,7 +64,10 @@ struct LayoutGeometryMapStep {

const LayoutObject* m_layoutObject;

LayoutSize m_offset;

OwnPtr<TransformationMatrix> m_transform; // Includes offset if non-null.

+ // If m_offsetForFixedPosition could only apply to the fixed position steps, we may be able to merge

+ // with m_offsetForStickyPosition and simplify mapping.

LayoutSize m_offsetForFixedPosition;

+ LayoutSize m_offsetForStickyPosition;

GeometryInfoFlags m_flags;

};