third_party/WebKit/Source/core/frame/FrameView.h - Issue 1308273010: Adapt and reland old position sticky implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make sticky vertical ref tests expectations not dependent on font size. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.h

diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h

index 9af4a9a2a6976443d58202a1e447edb820cf4b6f..77ed57d15d326aba24a4b720f9d3d51be3cf9669 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.h

+++ b/third_party/WebKit/Source/core/frame/FrameView.h

@@ -201,6 +201,11 @@ public:

const ViewportConstrainedObjectSet* viewportConstrainedObjects() const { return m_viewportConstrainedObjects.get(); }

bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; }

+ // Sticky objects.

+ void addStickyPositionObject() { ++m_stickyPositionObjectCount; }

+ void removeStickyPositionObject() { --m_stickyPositionObjectCount; }

+ bool hasStickyPositionObjects() const { return m_stickyPositionObjectCount; }

// Objects with background-attachment:fixed.

void addBackgroundAttachmentFixedObject(LayoutObject*);

void removeBackgroundAttachmentFixedObject(LayoutObject*);

@@ -826,6 +831,7 @@ private:

OwnPtrWillBeMember<ScrollableAreaSet> m_animatingScrollableAreas;

OwnPtr<ResizerAreaSet> m_resizerAreas;

OwnPtr<ViewportConstrainedObjectSet> m_viewportConstrainedObjects;

+ unsigned m_stickyPositionObjectCount;

ViewportConstrainedObjectSet m_backgroundAttachmentFixedObjects;

OwnPtrWillBeMember<FrameViewAutoSizeInfo> m_autoSizeInfo;