Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 1308273010: Adapt and reland old position sticky implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix style errors and remaining layout tests. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/layout/LayoutGeometryMap.cpp ('K') | « Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp ('k') | Source/core/page/scrolling/ScrollingConstraints.h » ('j') | Source/core/paint/DeprecatedPaintLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/Source/core/layout/compositing/CompositingReasonFinder.cpp b/Source/core/layout/compositing/CompositingReasonFinder.cpp

index b67ab287deb037fe0cfac35373bbdb880c2382a1..c3b6427a1ed66fb3a3daf01009c610039c65a155 100644

--- a/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -163,6 +163,9 @@ CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(cons

if (requiresCompositingForPositionFixed(layer))

directReasons |= CompositingReasonPositionFixed;

+ if (layer->scrollsWithScrollAncestor())

+ directReasons |= CompositingReasonPositionSticky;

directReasons |= layoutObject->additionalCompositingReasons();

ASSERT(!(directReasons & CompositingReasonComboAllStyleDeterminedReasons));