Source/core/layout/LayoutTableRow.h - Issue 1308273010: Adapt and reland old position sticky implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTableRow.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix style errors and remaining layout tests. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/layout/LayoutGeometryMap.cpp ('K') | « Source/core/layout/LayoutInline.h ('k') | Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h » ('j') | Source/core/paint/DeprecatedPaintLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutTableRow.h

diff --git a/Source/core/layout/LayoutTableRow.h b/Source/core/layout/LayoutTableRow.h

index 3cc7d3cbfb8bbfd0f6f1e09f14bd9417f2070539..16e363377800e9c75c2ead38c9baa7cb1806a3e7 100644

--- a/Source/core/layout/LayoutTableRow.h

+++ b/Source/core/layout/LayoutTableRow.h

@@ -126,7 +126,7 @@ private:

DeprecatedPaintLayerType layerTypeRequired() const override

{

- if (hasTransformRelatedProperty() || hasHiddenBackface() || hasClipPath() || createsGroup() || style()->shouldCompositeForCurrentAnimations() || style()->hasCompositorProxy())

+ if (hasTransformRelatedProperty() || hasHiddenBackface() || hasClipPath() || createsGroup() || style()->shouldCompositeForCurrentAnimations() || isStickyPositioned() || style()->hasCompositorProxy())

return NormalDeprecatedPaintLayer;

if (hasOverflowClip())