Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Store ancestor overflow layer on PaintLayer to compute before other dependent compositing inputs. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index 0f1f6553aed304a30d1286f42e05e937590400b2..f0718b9ba88c18f21147a69cd83f8f0c97e46d5e 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -1013,6 +1013,7 @@ private:
// Should check this object for paint invalidation.
if (!needsLayout())
setMayNeedPaintInvalidation();
+ invalidateScrollAncestorConstraints();
chrishtr 2016/03/09 16:53:08 Is this where you handle the case of an element wi
flackr 2016/03/14 19:04:26 Yes.
chrishtr 2016/03/16 21:52:39 Hmm. I'm trying to think of whether it is possible
flackr 2016/03/22 21:44:32 I'm fairly certain that transforms shouldn't be in
}
// Returns true if the box intersects the viewport visible to the user.

Powered by Google App Engine
This is Rietveld 408576698