third_party/WebKit/Source/core/style/ComputedStyle.h - Issue 1308273010: Adapt and reland old position sticky implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP - fix on release, still hits CHECK in LayoutGeometryMap.cpp:156 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.h

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h

index 6b9c3c8264588ca809c9da56d88cf6ac27a17842..a2dbd9f2f1d6fdcab5392391b4517fbaac570524 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.h

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h

@@ -497,7 +497,7 @@ public:

EPosition position() const { return static_cast<EPosition>(noninherited_flags.position); }

bool hasOutOfFlowPosition() const { return position() == AbsolutePosition || position() == FixedPosition; }

bool hasInFlowPosition() const { return position() == RelativePosition || position() == StickyPosition; }

- bool hasViewportConstrainedPosition() const { return position() == FixedPosition; }

+ bool hasViewportConstrainedPosition() const { return position() == FixedPosition || position() == StickyPosition; }

EFloat floating() const { return static_cast<EFloat>(noninherited_flags.floating); }

const Length& width() const { return m_box->width(); }