third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 1308273010: Adapt and reland old position sticky implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP - fix on release, still hits CHECK in LayoutGeometryMap.cpp:156 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index dcdb913ed6f3de401feb3c1694b0a6a6a8998cbf..f8b21db8d135f737405039e4a3f7ce22f496b32d 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -957,7 +957,8 @@ bool ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(Frame

for (const LayoutObject* layoutObject : *viewportConstrainedObjects) {

ASSERT(layoutObject->isBoxModelObject() && layoutObject->hasLayer());

- ASSERT(layoutObject->style()->position() == FixedPosition);

+ ASSERT(layoutObject->style()->position() == FixedPosition

+ || layoutObject->style()->position() == StickyPosition);

PaintLayer* layer = toLayoutBoxModelObject(layoutObject)->layer();

// Whether the Layer scrolls with the viewport is a tree-depenent

@@ -1006,6 +1007,8 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() co

if (frameView->hasBackgroundAttachmentFixedObjects())

reasons |= MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;

+ if (frameView->hasStickyPositionObjects())

+ reasons |= MainThreadScrollingReason::kHasStickyPositionObjects;

FrameView::ScrollingReasons scrollingReasons = frameView->scrollingReasons();

const bool mayBeScrolledByInput = (scrollingReasons == FrameView::Scrollable);

const bool mayBeScrolledByScript = mayBeScrolledByInput || (scrollingReasons ==

@@ -1031,6 +1034,8 @@ String ScrollingCoordinator::mainThreadScrollingReasonsAsText(MainThreadScrollin

stringBuilder.appendLiteral("Has background-attachment:fixed, ");

if (reasons & MainThreadScrollingReason::kHasNonLayerViewportConstrainedObjects)

stringBuilder.appendLiteral("Has non-layer viewport-constrained objects, ");

+ if (reasons & MainThreadScrollingReason::kHasStickyPositionObjects)

+ stringBuilder.appendLiteral("Has sticky position objects, ");

if (reasons & MainThreadScrollingReason::kThreadedScrollingDisabled)

stringBuilder.appendLiteral("Threaded scrolling is disabled, ");