Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1308273010: Adapt and reland old position sticky implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: WIP - fix on release, still hits CHECK in LayoutGeometryMap.cpp:156 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index a30ba9afb4329b55c08452c2a9d6c30f812f64e8..a6b81c3e29042be8d672c266b01e5ae3af96046f 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -200,6 +200,11 @@ public:
const ViewportConstrainedObjectSet* viewportConstrainedObjects() const { return m_viewportConstrainedObjects.get(); }
bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; }
+ // Sticky objects.
+ void addStickyPositionObject() { ++m_stickyPositionObjectCount; }
+ void removeStickyPositionObject() { --m_stickyPositionObjectCount; }
+ bool hasStickyPositionObjects() const { return m_stickyPositionObjectCount; }
+
// Objects with background-attachment:fixed.
void addBackgroundAttachmentFixedObject(LayoutObject*);
void removeBackgroundAttachmentFixedObject(LayoutObject*);
@@ -832,6 +837,7 @@ private:
OwnPtrWillBeMember<ScrollableAreaSet> m_animatingScrollableAreas;
OwnPtr<ResizerAreaSet> m_resizerAreas;
OwnPtr<ViewportConstrainedObjectSet> m_viewportConstrainedObjects;
+ unsigned m_stickyPositionObjectCount;
ViewportConstrainedObjectSet m_backgroundAttachmentFixedObjects;
OwnPtrWillBeMember<FrameViewAutoSizeInfo> m_autoSizeInfo;

Powered by Google App Engine
This is Rietveld 408576698