Adapt and reland old position sticky implementation

third_party/WebKit/Source/core/paint/PaintLayer.h

Index: third_party/WebKit/Source/core/paint/PaintLayer.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h
index d2d6ad4f006b486d5fea58582070e0347bf71926..adf7633a848fbc65761521369d54014656f6a171 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h
@@ -219,6 +219,9 @@ public:
     // Allows updates of layer content without invalidating paint.
     void contentChanged(ContentChangeType);
 
+    // Returns true if the position changed.
+    bool updateLayerPosition();

[chrishtr, 2015/12/11 02:06:12]

It appears no one cares about the return value of this method, change to void.

[flackr, 2016/01/19 15:40:48]

Done.

+
     void updateLayerPositionsAfterLayout();
     void updateLayerPositionsAfterOverflowScroll(const DoubleSize& scrollDelta);
 
@@ -540,7 +543,13 @@ public:
     void updateDescendantDependentCompositingInputs(const DescendantDependentCompositingInputs&);
     void didUpdateCompositingInputs();
 
-    const AncestorDependentCompositingInputs& ancestorDependentCompositingInputs() const { ASSERT(!m_needsAncestorDependentCompositingInputsUpdate); return m_ancestorDependentCompositingInputs; }
+    const AncestorDependentCompositingInputs& ancestorDependentCompositingInputs() const
+    {
+        // TODO(flackr): When we process scroll updates after compositing updates we won't be querying ancestor
+        // dependent compositing inputs while they're still needed: http://crbug.com/420741.
+        ASSERT(isAllowedToQueryCompositingState() || !m_needsAncestorDependentCompositingInputsUpdate);
+        return m_ancestorDependentCompositingInputs;
+    }
     const DescendantDependentCompositingInputs& descendantDependentCompositingInputs() const { ASSERT(!m_needsDescendantDependentCompositingInputsUpdate); return m_descendantDependentCompositingInputs; }
 
     IntRect clippedAbsoluteBoundingBox() const { return ancestorDependentCompositingInputs().clippedAbsoluteBoundingBox; }
@@ -628,9 +637,6 @@ private:
 
     void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
 
-    // Returns true if the position changed.
-    bool updateLayerPosition();
-
     void updateLayerPositionRecursive();
     void updateLayerPositionsAfterScrollRecursive(const DoubleSize& scrollDelta, bool paintInvalidationContainerWasScrolled);